Toddler keeps giving himself an erect!on

This is a very much boy thing. His age is a big determinating factor to how inappropriate this action is. If he's doing it in public that's an obvious no thing. In his own home where he's comfortable is an average situation. It did surprise me when I found out how often erections happen like throughout each day ever since my son was newborn phase and currently just turned 3. I tell my son he can do that if he's in his room or the bathroom alone. Still a learning thing given his age. Please keep in mind that impulse control isn't fully developed to a child is about 8 years old but definitely learning is part of it.

Sounds harmless, and if you stop giving him attention for it, it is something he's likely to outgrow. I'd probably just ignore it.

My boy (nearly 3) loves to play with his penis too. And he does try to put lots of different things against it, anything from clothings items to his toys. I personally think it’s a natural exploration and sensory/feel good thing and I don’t dismiss it nor stop it (a gentle redirect at times especially if I’m cleaning a nappy).

I’d be less inclined to stop it, allow him time and space to explore his body, and perhaps ask yourself why you’re uncomfortable with it?

Your projecting dislike onto him for it so he’s using that as a way to rebel. It feels nice to him so the end result could be shame in something that’s natural?

Have you tried explaining how his body works to him and that his penis is a private area? So he gets an idea of what behaviour is appropriate for when he’s in his bedroom vs outside around the rest of the home and outside etc?